-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring bug fixes and readme updates to the develop branch #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…BRESOURCE_INFO* Adds overloads for all 3 `UpdateSubresources` and `MemcpySubresource` which takes `D3D12_SUBRESOURCE_INFO` (which stores an offset rather than an absolute pointer) and a `const void*` rather than `D3D12_SUBRESOURCE_DATA`, which is useful in several scenarios working with D3D from .NET (where interior data pointers cannot be trivially passed around or stored on the heap),
adding yaml frontmatter for onboarding to the DMC Samples Browser
Add UpdateSubresource and MemcpySubresource overloads taking D3D12_SUBRESOURCE_INFO*
Adding yaml for DMC sample browser: 11on12 and Bundles.
…plesBrowser Add platform to the urlFragment in the readme
…wser Onboard remaining Direct3D 12 samples to the DMC Samples Browser.
The p is necessary for position, the v is not a valid option. And since v will be discarded, and position is not specified, the application will just exit.
In MeshProcessor class m_indexSize field should be updated to 4 if 32bit indices are forced and not needed. Before this change the resulting IB was still treated as 16bit afterwards - Finalize<uint16_t> was being called.
Fix meshlet generation, when 32bit indices are forced
Fix wrong example in the help
Minor code review for d3dx12
…section in the readme so people can more easily workaround a VS bug.
19041 SDK and readme updates
Fix a copy error during the build process by using the MiniEngine spona.h3d file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes: